[codex] Preserve successful deployment status#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
DeployBot selected the newest deployment run by creation time. GitHub dispatched the same exact-main deployment twice: the first run completed successfully, while workflow concurrency cancelled the second. The cancelled duplicate therefore replaced valid release evidence and made
deploybot status --jsonreportdeploy-failedeven though production had deployed successfully.Impact
Status and release-following now treat the successful run as the durable release result only when the newer duplicate was cancelled. A later real failure still reports
deploy-failed.Validation
PYTHONPATH=src python3 -m unittest tests.test_pipeline.PipelineTest.test_successful_deploy_survives_later_cancelled_duplicate tests.test_pipeline.PipelineTest.test_later_failed_deploy_is_not_hidden_by_older_successPYTHONPATH=src python3 -m unittest discover -s tests(270 tests)ruff check .